Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow CLI integration module #139
Flow CLI integration module #139
Changes from 42 commits
008c2dd
68f028f
44c56fe
5ebb4b5
5407789
f88f543
36fe8cc
ae3a4e8
22ae84f
ee096ef
2761f4f
76efe32
e7b522d
3d5e090
74e886f
fff693f
3fc5725
a27de6e
0b442da
c846d7a
ba23ec0
d9e6429
3ab05a4
a15ec75
aef1430
b64e6f5
15c6af4
b545e34
1413f84
7b2c744
3979c07
72d47fb
ac0de9c
5ab8487
df822b5
7fa911b
3a40496
c9d9b9b
64157fd
d7d23df
5eb4677
b9c3a23
2f99052
c8cdca2
f2b237d
3a4e77b
ed3e4f3
1383496
abc367b
2776b06
7685fb2
b13e622
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the child process (Flowser) keeps running on Windows after you kill the parent (go program).
I'm not sure why that's the case, but it seems to be the default behavior on Windows. Here is the orphan process info:
![image](https://user-images.githubusercontent.com/36109955/202806965-9bdb61ef-0ba7-47a8-aad9-2a0a16f774cf.png)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not the highest priority, so we can fix this at some later point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good point!