Initial commit of Extreme BGP driver.

[llamAtExtreme]

No description provided.

[subh007]

@llamAtExtreme I think the exteme driver is exactly similar to mininet driver, in that case I would suggest to use the same mininet driver without adding code duplication.

Please let me know your thoughts.

[llamAtExtreme]

Hi Subhash,
The code is based off the Mininet driver since that was the only example that somewhat worked for us. There are some changes in the driver class, the Mininet driver throws a null pointer when we attempt to delete the route so a change was needed. The Extreme S-series switch also requires a different buffer ID to configure the flows. We could rewrite the driver to inherit off the Mininet driver and override the methods we changed.

Thanks,
Leo

From: Subhash Kumar Singh [mailto:notifications@github.com]
Sent: Friday, June 10, 2016 5:33 AM
To: onfsdn/atrium-odl atrium-odl@noreply.github.com
Cc: Leo Lam llam@extremenetworks.com; Mention mention@noreply.github.com
Subject: Re: [onfsdn/atrium-odl] Initial commit of Extreme BGP driver. (#15)

@llamAtExtremehttps://github.com/llamAtExtreme I think the code is exactly similar to mininet driver, in that case I would suggest to use the same mininet driver without adding code duplication.

Please let me know your thoughts.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/15#issuecomment-225137620, or mute the threadhttps://github.com/notifications/unsubscribe/AS59-6P02u2qj0uiCAc3_YsLP2U2Bt5Oks5qKS9CgaJpZM4Ix-5Q.

---

DISCLAIMER:
This e-mail and any attachments to it may contain confidential and proprietary material and is solely for the use of the intended recipient. Any review, use, disclosure, distribution or copying of this transmittal is prohibited except by or on behalf of the intended recipient. If you have received this transmittal in error, please notify the sender and destroy this e-mail and any attachments and all copies, whether electronic or printed.

[subh007]

Then bufferid should be -1 for the mininet driver, we can fix it in mininet driver as well

[subh007]

Hello Leo,

[1] The fix for buffer id is also required for the mininet driver. That I will fix and commit.
[2] I didn't find any difference in flow deletion, could you please let me know for it.

if there is no changes for the [1] and [2] then we can reuse the mininet driver for Extreme switches.

[llamAtExtreme]

Hi Subhash,
In the Extreme driver at line 308

Integer nextId = fwd.getNextId();
if(nextId == null)
nextId = new Integer(DEFAULT_GROUP_ID);

GroupActionBuilder actionBuilder_t = new GroupActionBuilder().setGroupId(nextId.longValue());

Calling fwd.getNextId().longValue() throws a null pointer when deleting the route(s).

From: Subhash Kumar Singh [mailto:notifications@github.com]
Sent: Monday, June 13, 2016 3:36 AM
To: onfsdn/atrium-odl atrium-odl@noreply.github.com
Cc: Leo Lam llam@extremenetworks.com; Mention mention@noreply.github.com
Subject: Re: [onfsdn/atrium-odl] Initial commit of Extreme BGP driver. (#15)

Hello Leo,

[1] The fix for buffer id is also required for the mininet driver. That I will fix and commit.
[2] I didn't find any difference in flow deletion, could you please let me know for it.

if there is no changes for the [1] and [2] then we can reuse the mininet driver for Extreme switches.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/15#issuecomment-225508334, or mute the threadhttps://github.com/notifications/unsubscribe/AS59-4B1aLEKP_KnLJcS70z4ODwnOFJKks5qLQhmgaJpZM4Ix-5Q.

---

DISCLAIMER:
This e-mail and any attachments to it may contain confidential and proprietary material and is solely for the use of the intended recipient. Any review, use, disclosure, distribution or copying of this transmittal is prohibited except by or on behalf of the intended recipient. If you have received this transmittal in error, please notify the sender and destroy this e-mail and any attachments and all copies, whether electronic or printed.