Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VUS-190] Crear servicio de credenciales #50

Merged
merged 13 commits into from
Mar 21, 2022
Merged

[VUS-190] Crear servicio de credenciales #50

merged 13 commits into from
Mar 21, 2022

Conversation

fedelmar
Copy link
Contributor

  • Se crea servicio createCert, para la creación de una credencial
  • Se crea servicio emmitCert, para emitir una credencial en base a un id
  • Se agregan tests en casos de exito

MatiasOS
MatiasOS requested changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@MatiasOS MatiasOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta considerar los try catch en Issuer Service cuando no reponder el emisor. Por ejemplo haces POST a CREATE_CREDENTIAL y DIDI Issuer no responde.

src/services/IssuerService.js Outdated Show resolved Hide resolved
src/services/IssuerService.js Outdated Show resolved Hide resolved
src/services/CredentialService.js Outdated Show resolved Hide resolved
__tests__/services/mock/constants.js Outdated Show resolved Hide resolved
__tests__/services/mock/constants.js Outdated Show resolved Hide resolved
__tests__/services/mock/constants.js Outdated Show resolved Hide resolved
__tests__/services/mock/constants.js Outdated Show resolved Hide resolved
src/services/CredentialService.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MatiasOS
MatiasOS approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@MatiasOS MatiasOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@MatiasOS MatiasOS merged commit ed2b7ce into develop Mar 21, 2022
@MatiasOS MatiasOS deleted the VUS-190/crear-servicio-de-credenciales branch March 21, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatiasOS MatiasOS MatiasOS approved these changes

@DoloresGarciaE DoloresGarciaE Awaiting requested review from DoloresGarciaE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedelmar @MatiasOS @DoloresGarciaE