This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Feature - Browser: Add experimental configuration and stub out UX #1233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the new
layer
API to create aBrowserLayer
, which renders an electron webview over a buffer. This allows us to spin up browser windows, but using the same window management we're accustomed to from Vim.To enable this functionality, you'll need to set
experimental.browser.enabled
totrue
. You can test it out by clicking one of our URLs like the onivim homepage inHelp
. In addition, you can run this in console:Oni.commands.executeCommand("browser.openUrl", "https://www.onivim.io")
to navigate to a custom page. You can do some cool stuff with this - like register a command or bind a key to open localhost for previewing, etc.Here's what things look like right now:
Lots of things remaining...