Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Bugfix - Regression: First run of Oni doesn't open a window #2380

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jul 1, 2018

This is a regression of #2377 - the manifestation is that, when first launching Oni, nothing happens - it takes a second launch to actually see the window.

The issue is that, we call makeSingleInstance, and the callback for that gets fired when any additional instance is opened, however, we weren't handling the initial case - if isSecondInstance is false, than we need to kick off the window launch explicitly after the 'ready' event is fired.

Thanks @CrossR for catching this! 💯

@bryphe bryphe changed the title Bugfix - regression: First run of Oni doesn't open WIndow Bugfix - Regression: First run of Oni doesn't open WIndow Jul 1, 2018
@bryphe bryphe changed the title Bugfix - Regression: First run of Oni doesn't open WIndow Bugfix - Regression: First run of Oni doesn't open a window Jul 1, 2018
Copy link
Member

@CrossR CrossR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it for me!

@codecov
Copy link

codecov bot commented Jul 1, 2018

Codecov Report

Merging #2380 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2380   +/-   ##
======================================
  Coverage    38.1%   38.1%           
======================================
  Files         300     300           
  Lines       12522   12522           
  Branches     1646    1646           
======================================
  Hits         4771    4771           
  Misses       7497    7497           
  Partials      254     254

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8919a86...a213879. Read the comment docs.

@bryphe bryphe merged commit cf1e75b into master Jul 1, 2018
@bryphe bryphe deleted the bryphe/regression/make-single-instance-launch branch July 1, 2018 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants