Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motions like vi"[{... etc not working #1880

Closed
pmizio opened this issue Jun 6, 2020 · 1 comment · Fixed by #2429
Closed

Motions like vi"[{... etc not working #1880

pmizio opened this issue Jun 6, 2020 · 1 comment · Fixed by #2429
Labels
A-vim Area: Vim/modal editing bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor U-libvim Upstream: Potentially dependent on changes in libvim

Comments

@pmizio
Copy link

pmizio commented Jun 6, 2020

I belive oni(lib-vim) not count v as operator it only begins visual mode
@glennsl glennsl added A-vim Area: Vim/modal editing U-libvim Upstream: Potentially dependent on changes in libvim bug Something isn't working labels Jun 7, 2020
@mabuchner mabuchner mentioned this issue Jul 24, 2020
Closed
@mabuchner
Copy link

mabuchner commented Aug 31, 2020 •
edited

@bryphe Why isn't this a "I-daily-editor-blocker"? I use it all the time for yanking, deleting and replacing text.

E.g. vi)"ap, will replace the text inside the surrounding brackets with the contents of the register a.

I know, I could also do ci)<C-R>a instead, but I like to see the visual selection before doing any modifications.

@mabuchner mabuchner mentioned this issue Sep 6, 2020
Closed
@CrossR CrossR added the I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor label Sep 7, 2020
This was referenced Sep 9, 2020
Merged
Merged
bryphe added a commit to onivim/libvim that referenced this issue Sep 10, 2020
@bryphe
test(visual): Add test case for visual in-motion
f896e5a 
Add test case covering onivim/oni2#2413 & onivim/oni2#1880
bryphe added a commit that referenced this issue Sep 11, 2020
@bryphe
fix(vim/#2413): Visual-in motion (viw/vi"/etc) not working correctly (#…
6a758ea 
…2429)

__Issue:__ Visual motions - like `viw` or `vi"` are not working as expected. 

__Defect:__ At first, I thought this might be an issue in `libvim` - so I added a test case in onivim/libvim#223 - surprisingly, it passed, but the same set of keystrokes was not working as expected in Onivim.

I checked the logging I added for onivim/libvim#223, and the code path that handles the 'in' motion in visual mode wasn't being hit. It turns out, our terminal key-bindings are incorrectly defined, and were getting engaged in this case (since we manage terminal insert <-> normal transition in Onivim, we have keybindings that handle keys like 'i', but there were getting engaged in the `vi"` case, even though they shouldn't).

__Fix:__ Scope the insert-mode transition keys (i/a/etc) to _only_ the case where the terminal is focused and we're in normal mode. Move them to be local to the terminal feature.

Fixes #2413  
Fixes #1880  
Fixes #2270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vim Area: Vim/modal editing bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor U-libvim Upstream: Potentially dependent on changes in libvim
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vim/#2413): Visual-in motion (viw/vi"/etc) not working correctly onivim/oni2
4 participants
@pmizio @glennsl @mabuchner @CrossR