Integrated Terminal: 'oni2' command should open file in current editor

[bryphe]

Expected: When running the oni2 command to open a file, ie, oni2 some-file.txt, the expectation is that the file would open in the current_session.

Actual: A new Oni2 window is created, which isn't very useful behavior.

I thought we had an issue logged for this already - but couldn't find it.

Related to #1250 - solving that issue would likely solve this one, too. We can potentially pass an environment variable / some context so that a 'nested' Onivim 2 process knows there is already an instance running, and can let it know to open a file.

[vincentjorgensen]

On MacOS, these directions here do not add the oni2 symlink to /usr/local/bin. (Nothing happens when I click on it. I am using latest b7d274a) How do I add it manually? Thank you.

[bryphe]

Hi @vincentjorgensen ,

If the Add to Symlink command isn't working - you can run this command in terminal:

ln -fs /Applications/Onivim2.app/Contents/Resources/run.sh /usr/local/bin/oni2

(Assuming you've installed via the DMG). Hope that helps - let me know if it's still not working.

[vincentjorgensen]

Thank you. The instructions work. However, `oni2 <file>` opens each new file in a new instance of the app.

…

On Tue, Apr 27, 2021 at 2:36 PM Bryan Phelps ***@***.***> wrote: Hi @vincentjorgensen <https://github.com/vincentjorgensen> , If the Add to Symlink command isn't working - you can run this command in terminal: ln -fs /Applications/Onivim2.app/Contents/Resources/run.sh /usr/local/bin/oni2 (Assuming you've installed via the DMG). Hope that helps - let me know if it's still not working. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHAF64SY6CEFHNVOIXUMVDTK4U4NANCNFSM4P64IJOA> .

[CrossR]

Thank you. The instructions work. However, oni2 <file> opens each new file in a new instance of the app.

That is step 2 in the process! Step 1 is this issue, i.e. have oni2 work properly inside Oni2. To my knowledge, its not been generalised to work outside the editor quite yet, as the way we communicate with the running Oni2 instance isn't accessible outside the editor right now (well it is...but we've not setup a way of locating it).

So that is working as expected right now, but keep an eye out and that should start working, once the behaviour has been expanded a little.

[vincentjorgensen]

OK! Got it! Thank you! Much obliged.

…

On Tue, Apr 27, 2021 at 2:46 PM Ryan C ***@***.***> wrote: Thank you. The instructions work. However, oni2 <file> opens each new file in a new instance of the app. That is step 2 in the process! Step 1 is this issue, i.e. have oni2 work properly inside Oni2. To my knowledge, its not been generalised to work outside the editor quite yet, as the way we communicate with the running Oni2 instance isn't accessible outside the editor right now (well it is...but we've not setup a way of locating it). So that is working as expected right now, but keep an eye out and that should start working, once the behaviour has been expanded a little. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHAF633N4FQUVX3AIUQJR3TK4WCJANCNFSM4P64IJOA> .