Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Operator-pending indicators #2357

Open
LeonT-A opened this issue Aug 24, 2020 · 0 comments
Open

Request: Operator-pending indicators #2357

LeonT-A opened this issue Aug 24, 2020 · 0 comments
Labels
A-vim Area: Vim/modal editing bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor

Comments

@LeonT-A
Copy link

LeonT-A commented Aug 24, 2020 •
edited

Vim provides you with a key-indication to let you know when you are in operator-pending mode and what operator triggered it.

At the moment, OniVim only tells you that 'Operator' mode is active, but no indication of what kind of operator is pending.

There is also no indication that you've entered operator-pending mode from Visual mode, nor any indication for commands such as ctrl-w
@LeonT-A LeonT-A changed the title Request: Operator-pending indicaters Request: Operator-pending indicators Aug 24, 2020
@bryphe bryphe added A-vim Area: Vim/modal editing bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor labels Aug 24, 2020
@bryphe bryphe mentioned this issue Aug 26, 2020
Merged
bryphe added a commit that referenced this issue Aug 26, 2020
@bryphe
fix(vim): Add infrastructure for additional mode context (#2362)
354a87e 
Some prep work to address #2357 - this plumbs through some additional context for modes, so that we can display it in the status bar and elsewhere. This updates the `Mode` variant to be able to handle contextual state (and updates all the downstream dependencies).

With this change - we'll be able to integrate it with onivim/libvim#218 so we can add some operator pending info for #2357
@bryphe bryphe mentioned this issue Aug 26, 2020
Merged
bryphe added a commit that referenced this issue Aug 26, 2020
@bryphe
fix(vim/#2357): Part 1 - Show pending operator in status bar (#2364)
e6a1d19 
__Issue:__ As described in #2357 , we weren't showing any context around a pending operator in the status bar - this is really a step backward.

__Fix:__ This picks up onivim/libvim#218 so that we get some context around the current pending operator, and we show it in now in the statusbar:

![2020-08-26 12 56 23](https://user-images.githubusercontent.com/13532591/91350541-b02e6880-e79b-11ea-8015-2670a7bf690f.gif)

This fixes the operator-pending part of #2357 - we're missing showing the in-progress count of a command, though.
@bryphe bryphe mentioned this issue Aug 28, 2020
Merged
bryphe added a commit that referenced this issue Aug 29, 2020
@bryphe
feat(vim): Macro indicator in status bar (#2373)
2153ed0 
__Issue:__ There was no UI affordance to show when a macro was being recorded (tangentially related to #2357 )

__Fix:__ Add a recording indicator while a macro is being recorded:

![2020-08-28 14 19 19](https://user-images.githubusercontent.com/13532591/91616033-bce8c300-e939-11ea-8990-89486051822d.gif)
@bryphe bryphe mentioned this issue Feb 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vim Area: Vim/modal editing bug Something isn't working I-daily-editor-blocker An issue blocking use of the editor as a day-to-day editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryphe @LeonT-A