Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu does not cycle from first to last item #314

Closed
gillchristian opened this issue May 8, 2019 · 1 comment · Fixed by #894
Closed

Menu does not cycle from first to last item #314

gillchristian opened this issue May 8, 2019 · 1 comment · Fixed by #894
Assignees
@glennsl
Labels
bug Something isn't working enhancement New feature or request

Comments

@gillchristian
Copy link

gillchristian commented May 8, 2019 •
edited

The menu (quickopen and commandPalette) cycles on MenunextItem from last to first. But does not cycle from first to last on MenuPreviousItem.

If this is something that should be added I already can open a PR with the fix.
@gillchristian gillchristian mentioned this issue May 8, 2019
Closed
@CrossR CrossR added bug Something isn't working enhancement New feature or request labels May 10, 2019
@benox3 benox3 mentioned this issue Oct 8, 2019
Closed
@glennsl
Copy link
Member

glennsl commented Oct 10, 2019

FYI: I'm working on this as part of the menu renovation project.

@glennsl glennsl self-assigned this Oct 10, 2019
@glennsl glennsl mentioned this issue Oct 15, 2019
Closed
18 tasks
@glennsl glennsl mentioned this issue Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennsl glennsl

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Menu Renovation - Part 1: Easy pickings glennsl/oni2
3 participants
@glennsl @gillchristian @CrossR