Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu (FlatList) viewport doesn't follow the selected item #321

Closed
gillchristian opened this issue May 18, 2019 · 1 comment · Fixed by #894
Closed

Menu (FlatList) viewport doesn't follow the selected item #321

gillchristian opened this issue May 18, 2019 · 1 comment · Fixed by #894
Assignees
Labels
bug Something isn't working

Comments

@gillchristian
Copy link

gillchristian commented May 18, 2019

When there are more items than the Menu/FlatList shows it doesn't follow the selectedItem.

You can see here: https://www.youtube.com/watch?v=xPhhNNhfVkM

I changed my menu config form <C-N>/<C-P> to <C-J>/<C-K>.

I'd like to give it a shot at fixing it.


Here is what I believe should be the behavior for the menu

List shorter than view:

Current:

current-short-list

Expected? (This is how VS Code menu works)

expected-short-list

List is longer than view

Current

current-longer-list

Expected

expected-longer-list

@CrossR CrossR added the bug Something isn't working label Jun 22, 2019
@glennsl
Copy link
Member

glennsl commented Oct 10, 2019

FYI: I'm working on this as part of the menu renovation project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants