Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling initial [No Name] Buffer #81

Closed
akinsho opened this issue Feb 24, 2019 · 1 comment · Fixed by #1044
Closed

Handling initial [No Name] Buffer #81

akinsho opened this issue Feb 24, 2019 · 1 comment · Fixed by #1044
Labels
A-ux Area: Overall user experience and aesthetics E-help-wanted Call for participation: Help is requested to fix this issue. enhancement New feature or request

Comments

@akinsho
Copy link
Member

akinsho commented Feb 24, 2019

This issue is more of a brain dump regarding what I've found about this buffer since it has proven to be non-trivial to handle. This issue relating to it first came up in #72. Currently once #76 is merged, it will show its modified status correctly and close when the cross is clicked.

If it is navigated away from on start, it is discarded. If it is modified then a user tries to return to it, currently it silently fails in Oni2.

I've found that actually this is the same behavior as terminal neovim which is actually errorring with E499: Empty file name for '%' or '#', only works with ":p:h". Essentially we're not allowed to navigate to a file without a name, which this file does not have nor does using its id work.

It can still be closed though. I think as what it does is default vim behavior this is fine for now, It makes me think though that even at this early stage it might be worth considering a splash screen and only opening buffers a user has chosen to open.

Either way we aren't doing anything that differs from neovim, but it highlights the fact that we aren't rendering errors which is confusing but should be fixed once we pick up the ext_messages change in nvim 0.4.0

@bryphe
Copy link
Member

bryphe commented Feb 27, 2019

It makes me think though that even at this early stage it might be worth considering a splash screen and only opening buffers a user has chosen to open.

I like this idea a lot! Sort of like the 'Welcome' screen we prototyped in Oni1 that didn't make it in. Seems like it would smooth over this case for sure

@CrossR CrossR added enhancement New feature or request E-help-wanted Call for participation: Help is requested to fix this issue. labels Apr 27, 2019
@glennsl glennsl added the A-ux Area: Overall user experience and aesthetics label Nov 18, 2019
bryphe added a commit that referenced this issue Dec 27, 2019
* Start infra for welcome experience

* Welcome tweaks

* Add some initial animations

* Override name for Welcome renderer

* Override tab name

* Tweaks

* Fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ux Area: Overall user experience and aesthetics E-help-wanted Call for participation: Help is requested to fix this issue. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants