-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocaml-decoders conversion experiment #1280
Changes from all commits
45c15a1
1f9a186
235073d
aa78b63
d37baa9
45e303b
49a00aa
da81252
853aecf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
ocaml-decoders
, but the license is justISC
. Literally, that is the entire license text. So should I just add that to the end here, find the text of the ISC license from somewhere else, or just leave it as-is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This in particular ought to be addressed before merging @bryphe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks for the ping @glennsl ! Definitely - sorry I missed this.
Let's just add the ISC license text (from here: https://opensource.org/licenses/ISC)
Thanks for checking in on this!