Feature/add tab mapping #1450
Feature/add tab mapping #1450
Conversation
There was a problem hiding this comment.
Thank @jakeday! Almost perfect execution as well!But I do have one correction below.
I'm also wondering where this keybinding originates from. It doesn't seem to be vscode, which does have something similar but with a different default. And ideally we'd use vscode's defaults.
|
Also, you need to run |
|
@glennsl I don't know why the check failed, but it generated the artifacts. I tested them and they appear to be working correctly. |
|
/azp run |
| @@ -179,6 +179,16 @@ let start = () => { | |||
| command: "workbench.action.files.save", | |||
| condition: "editorTextFocus" |> WhenExpr.parse, | |||
| }, | |||
| { | |||
| key: "<TAB>", | |||
There was a problem hiding this comment.
Still wondering where this keybinding comes from, and leaning towards the default being Ctrol+], since that's the default for vscode. After all, we aim to be vscode/vim hybrid first and foremost.
There was a problem hiding this comment.
I use tab and shift-tab in VSCode with no extensions to indent and unindent blocks of code, though I can only see the action bound to Ctrl-[] in the docs...but it does work, so not so sure.
There was a problem hiding this comment.
Is it a vscodevim thing perhaps?
There was a problem hiding this comment.
Don't think so! I use it on clean machines helping students out in programming labs, and its worked across every machine I've tried, so I think it must be default to VSCode since the only plugins they have installed is the Python one.
There was a problem hiding this comment.
Ah, yeah it doesn't work with vscodevim, but does work with a selection if I disable it. And of course it works if I put the cursor at the beginning of the line. So I guess that's just part of the "core" editor experience.
Should we have both bindings then? They aren't entirely identical since the "proper" keybinding will indent the line even without a selection, but that's closer to what's been implemented here anyway.
Also, on macOS the keybinding is Ctrl+Alt+Cmd+8 to outdent and Ctrl+Alt+Cmd+9 to indent.
There was a problem hiding this comment.
@glennsl I added the mappings for the CTRL+] and CTRL+[ for indenting and outdenting. With the current mappings in this PR, we can support both typical use cases for users who will expect to be able to use these shortcuts regardless of which editor they are use to.
There was a problem hiding this comment.
Thanks @jakeday. Could you implement my second suggestion as well? Unless you don't think it's a good idea for some reason.
There was a problem hiding this comment.
@glennsl Are you wanting the command to be just "indent" or "editor.action.indent"?
There was a problem hiding this comment.
I'd like Tab to be just indent and S-Tab to be just outdent, since the latter actually exists as a keybinding in vscode. indent is oddly missing, so we'll just have to infer that one.
Taking a stab add adding the Visual Mode mapping and adding support for tab and shift tab to indent and outdent when in the visual mode.