Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Game History Table #1259

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

GreenAsJade
Copy link
Contributor

@GreenAsJade GreenAsJade commented Nov 9, 2020

Proposed Changes

As discussed in this thread: https://forums.online-go.com/t/update-of-game-history-table/31742

  • Get rid of the "Black" and "White" player columns, and have just "Opponent", for major redundant information removal
  • Have a column for the colour of the current player
  • Reorder the columns to make this look good
  • Grey-out annulled games

Screen Shot 2020-11-09 at 2 24 59 pm

@anoek
Copy link
Member

anoek commented Nov 9, 2020

This looks great :)

@anoek anoek merged commit 039151a into online-go:devel Nov 9, 2020
@anoek
Copy link
Member

anoek commented Nov 9, 2020

Thanks @GreenAsJade , very nice improvement 👍

@benjaminpjones
Copy link
Contributor

benjaminpjones commented Nov 9, 2020

Heads up- I am seeing much more transparency for annulled games on beta than I see when I run it locally. Not sure what is causing it though- the source looks fine to me.

Screen Shot 2020-11-09 at 10 14 59 AM

EDIT: Looks like the folks on the forums found this first

@anoek
Copy link
Member

anoek commented Nov 9, 2020

Thanks for the heads up, that's a bit of a mystery. I "fixed" it with 0d70674 by changing opacity from 30% to 0.3, it's not clear to me why it worked on dev and not release at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants