Change top 3 game changing moves to worst 3 moves #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't treat positive win rate changes as game changing.
|
I think I agree with this, I'm going to update the backend to match for the quick top 3 analysis at the same time as I merge and roll this out I think. |
|
Thanks for this! Sorry it took so long to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, a game changing move is a move which deviates much from perfect play. Since we don't know what perfect play would look like, we approximate it by using an AI.
Positive win rate changes are an artefact of the limited AI, not a sing for a game changing move. Therefore, we shouldn't include positive changes in the Top 3. (positive changes are rarely in the top 3 anyway, since their abs is usually small)