Migrate to Swift 5 / Xcode 11 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ephread Thanks for the PR, I like it. Working with pointer in Swift is not fun 😄 I think for empty data we end up creating no xml children, so I guess that is fine for now |
|
Sweet, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all issues reported by Xcode 11.6.
Due to the deprecation of…
… I used Michael Tsai's approach to bind the memory from
UnsafeRawBufferPointerto aUnsafePointer<ContentType>reference.I wonder if I should handle the case on an empty
Data(count == 0) instance intoPointer()though. 🤔I hope the PR is small enough, let me know what you think!