Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse lit tests with ONNX textual syntax #2262

Merged
merged 10 commits into from
May 25, 2023

Conversation

sorenlassen
Copy link
Member

@sorenlassen sorenlassen commented May 23, 2023

Added onnx-mlir support for models expressed with ONNX textual syntax in files with .onnxtext extension. Converted some parse lit tests, resulting in more concise and readable tests and obviating the utils/testing python programs to generate the models.

This PR was motivated by the need to write readable parse lit tests for function inlining in PR #2242.

Bundled unrelated cosmetic fix to indentation in test_strnormalizer_export_monday_casesensintive_nochangecase.json

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Copy link
Member

@philass philass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big quality of life improvement for our parsing lit tests.

Nice!

@sorenlassen sorenlassen merged commit f058a48 into onnx:main May 25, 2023
4 checks passed
@sorenlassen sorenlassen deleted the sorenlassen/onnxtext branch May 25, 2023 03:54
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #11258 [push] parse lit tests with ONN... started at 23:55

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #10306 [push] parse lit tests with ONN... started at 00:00

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #11248 [push] parse lit tests with ONN... started at 22:55

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #11248 [push] parse lit tests with ONN... passed after 1 hr 13 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #10306 [push] parse lit tests with ONN... passed after 2 hr 1 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #11258 [push] parse lit tests with ONN... passed after 2 hr 3 min

negiyas pushed a commit to negiyas/onnx-mlir that referenced this pull request Jul 31, 2023
* parse .onnxtext model files

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* include .onnxtext files in parse lit tests

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* utility to create .onnxtext files from .onnx models

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* convert test_abs.json parse lit test to test_abs.onnxtext

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* fix typo in comment

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* fix bad indentation

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* convert fusedmatmul.json parse lit test to fusedmatmul.onnxtext

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

* convert zipmap.json parse lit test to zipmap.onnxtext

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>

---------

Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
justinchuby added a commit to onnx/onnx that referenced this pull request Mar 30, 2024
Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
github-merge-queue bot pushed a commit to onnx/onnx that referenced this pull request Apr 4, 2024
…6051)

Usage seen in
https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext.
(onnx/onnx-mlir#2262). I added the `.onnxtext`
extension to be a known extension for the serializer.

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Apr 12, 2024
…nnx#6051)

Usage seen in
https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext.
(onnx/onnx-mlir#2262). I added the `.onnxtext`
extension to be a known extension for the serializer.

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
…nnx#6051)

Usage seen in
https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext.
(onnx/onnx-mlir#2262). I added the `.onnxtext`
extension to be a known extension for the serializer.

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants