-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse lit tests with ONNX textual syntax #2262
Conversation
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
Signed-off-by: Soren Lassen <sorenlassen@gmail.com>
16986cd
to
621aab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big quality of life improvement for our parsing lit tests.
Nice!
Jenkins Linux s390x Build #11258 [push] parse lit tests with ONN... started at 23:55 |
Jenkins Linux ppc64le Build #10306 [push] parse lit tests with ONN... started at 00:00 |
Jenkins Linux amd64 Build #11248 [push] parse lit tests with ONN... started at 22:55 |
Jenkins Linux amd64 Build #11248 [push] parse lit tests with ONN... passed after 1 hr 13 min |
Jenkins Linux ppc64le Build #10306 [push] parse lit tests with ONN... passed after 2 hr 1 min |
Jenkins Linux s390x Build #11258 [push] parse lit tests with ONN... passed after 2 hr 3 min |
* parse .onnxtext model files Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * include .onnxtext files in parse lit tests Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * utility to create .onnxtext files from .onnx models Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * convert test_abs.json parse lit test to test_abs.onnxtext Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * fix typo in comment Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * fix bad indentation Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * convert fusedmatmul.json parse lit test to fusedmatmul.onnxtext Signed-off-by: Soren Lassen <sorenlassen@gmail.com> * convert zipmap.json parse lit test to zipmap.onnxtext Signed-off-by: Soren Lassen <sorenlassen@gmail.com> --------- Signed-off-by: Soren Lassen <sorenlassen@gmail.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com>
Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
…6051) Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
…nnx#6051) Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
…nnx#6051) Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Added onnx-mlir support for models expressed with ONNX textual syntax in files with
.onnxtext
extension. Converted some parse lit tests, resulting in more concise and readable tests and obviating the utils/testing python programs to generate the models.This PR was motivated by the need to write readable parse lit tests for function inlining in PR #2242.
Bundled unrelated cosmetic fix to indentation in test_strnormalizer_export_monday_casesensintive_nochangecase.json