Include the ".onnxtext" extension in supported serialization format #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 506 506
Lines 30467 30467
Branches 4592 4592
=======================================
Hits 17353 17353
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
gramalingam
reviewed
Apr 3, 2024
gramalingam
approved these changes
Apr 3, 2024
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
…nnx#6051) Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
…nnx#6051) Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the `.onnxtext` extension to be a known extension for the serializer. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage seen in https://github.com/onnx/onnx-mlir/blob/5ef91c1be51eb578e61d2ae3c05fa821297a8ee2/test/mlir/onnx/parse/fun_model_test.onnxtext. (onnx/onnx-mlir#2262). I added the
.onnxtextextension to be a known extension for the serializer.