Support register custom OpSchema by python #9305
justinchubyAnnotations
8 warnings
|
clang-tidy:
onnx/defs/schema.cc#L41
warning: variable 'registration' of type 'OpSchemaRegistry::OpSchemaRegisterOnce' can be declared 'const' [misc-const-correctness]
```suggestion
OpSchemaRegistry::OpSchemaRegisterOnce ONNX_UNUSED const registration(
```
|
|
clang-tidy:
onnx/defs/schema.h#L1187
warning: method 'AddDomainToVersion' can be made static [readability-convert-member-functions-to-static]
```suggestion
static void AddDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
```
|
|
clang-tidy:
onnx/defs/schema.h#L1187
warning: 2 adjacent parameters of 'AddDomainToVersion' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters]
```cpp
void AddDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
^
```
<details>
<summary>Additional context</summary>
**onnx/defs/schema.h:1186:** the first parameter in the range is 'min_version'
```cpp
void AddDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
^
```
**onnx/defs/schema.h:1186:** the last parameter in the range is 'max_version'
```cpp
void AddDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
^
```
</details>
|
|
clang-tidy:
onnx/defs/schema.h#L1211
warning: method 'UpdateDomainToVersion' can be made static [readability-convert-member-functions-to-static]
```suggestion
static void UpdateDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
```
|
|
clang-tidy:
onnx/defs/schema.h#L1211
warning: 2 adjacent parameters of 'UpdateDomainToVersion' of similar type ('int') are easily swapped by mistake [bugprone-easily-swappable-parameters]
```cpp
void UpdateDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
^
```
<details>
<summary>Additional context</summary>
**onnx/defs/schema.h:1210:** the first parameter in the range is 'min_version'
```cpp
void UpdateDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
^
```
**onnx/defs/schema.h:1210:** the last parameter in the range is 'max_version'
```cpp
void UpdateDomainToVersion(const std::string& domain, int min_version, int max_version, int last_release_version) {
^
```
</details>
|
|
clang-tidy:
onnx/defs/schema.h#L1261
warning: variable name 'm' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto& m = GetMapWithoutEnsuringRegistration();
^
```
|
|
clang-tidy:
onnx/defs/schema.h#L1262
warning: 'auto &op_name' can be declared as 'const auto &op_name' [readability-qualified-auto]
```suggestion
const auto& op_name = op_schema.Name();
```
|
|
clang-tidy:
onnx/defs/schema.h#L1263
warning: 'auto &op_domain' can be declared as 'const auto &op_domain' [readability-qualified-auto]
```suggestion
const auto& op_domain = op_schema.domain();
```
|