New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental operator debug spew to std::cerr #2239
Labels
Milestone
Comments
FYI @linkerzhang, @faxu. |
this error message could be removed given exp ops has been removed since 1.5. Let's remove it in 1.6. |
Lets fix this in onnx 1.10... I will send out a PR |
Closing this as a duplicate of #3696. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When an older experimental operator is encountered,
check_node
inonnx/checker.cc
writes directly tostd::cerr
(rather than to some more proper logging mechanism) which shows up as direct spew to the user and looks rather unprofessional. For console apps, when loading a model, you see a long paragraph of messages. For a GUI app, this message isn't even seen anyway and isn't useful. Note the operators were already removed in a previous ONNX release, and thus the transitional warning isn't so important.In the context of ONNX runtime, which continues to support these experimental operators for backwards compatibility of older models, the diagnostic message adds no value and is confusing because they are still supported. If/when the shape inference logic is removed from core ONNX, ONNX runtime can adopt the schema and shape inference functions into itself for compat.
A list of older models affected:
coreml_MNIST.onnx
winmlperf_coreml_FNS-Candy
coreml_VGG16_ImageNet.onnx
cs_generalfeaturizer.onnx
keras2coreml_LSTM_ImageNet.onnx
onnxzoo_winmlperf_tiny_yolov2.onnx
winmlperf_coreml_Inceptionv3
winmlperf_coreml_MobileNet
winmlperf_coreml_SqueezeNet
Operators affected:
ImageScaler, Affine, Crop
Desired action:
Just remove the message.
Alternately: Support a CMakeList define, and #ifdef the block.
Pertinent Code
The text was updated successfully, but these errors were encountered: