Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ManagingExperimentalOps.md to include deprecated operators table #2555

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Update ManagingExperimentalOps.md to include deprecated operators table #2555

merged 1 commit into from
Jan 16, 2020

Conversation

fdwr
Copy link
Contributor

@fdwr fdwr commented Jan 16, 2020

Many experimental operators were removed from ONNX, including dozens used in client models for published applications, which now cause warnings to be written to the console in check_node. e.g. "Warning: Affine was a removed experimental op. In the future, we may directly reject this operator...". These warnings provide no guidance on what to do though, and they're confusing to the user given frameworks like ONNX Runtime continue to support these operators anyway for backwards compatibility. Since this is related to versioning, I'm proposing to document the guidance here (note we can't it in Operators.md because these operators don't exist anymore, and we can't include it in ChangeLog.md either because all records of these operators were removed).

Part of issue #2239.

@fdwr fdwr requested a review from a team as a code owner January 16, 2020 19:23
@fdwr fdwr changed the title Update Versioning.md to include 1.6 opset value and add deprecated operators table Update ManagingExperimentalOps.md to include deprecated operators table Jan 16, 2020
@fdwr
Copy link
Contributor Author

fdwr commented Jan 16, 2020

FYI @prasanthpul.

@prasanthpul prasanthpul merged commit 3613eb2 into onnx:master Jan 16, 2020
@winnietsang winnietsang added this to the 1.7 milestone Feb 12, 2020
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants