Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Versioning.md to include 1.6 opset value and add deprecated operators table #2384

Closed
wants to merge 97 commits into from

Conversation

fdwr
Copy link
Contributor

@fdwr fdwr commented Oct 2, 2019

The 1.6 release missed adding a row for opset 11 to the table.

Many experimental operators were removed from ONNX, including dozens used in client models for published applications, which now cause warnings to be written to the console in check_node. e.g. "Warning: Affine was a removed experimental op. In the future, we may directly reject this operator...". These warnings provide no guidance on what to do though, and they're confusing to the user given frameworks like ONNX Runtime continue to support these operators anyway for backwards compatibility. Since this is related to versioning, I'm proposing to document the guidance here (note we can't it in Operators.md because these operators don't exist anymore, and we can't include it in ChangeLog.md either because all records of these operators were removed).

Part of #2239.

fdwr added 30 commits August 29, 2019 10:29
Support ScatterND operator in ONNX
* Update to include ONNX Foundation WG

Added link to Gitter and description of the newly formed Foundation WG. Co-leaders Jim Spohrer (IBM) and Ryan Loney (Intel)

* Updated description of Foundation WG

Revised the description of the working group for ONNX Foundation

* Update working-groups.md
with type default values even though they are not in the stream.
Move map and sequence types to onnx domain, this is the first step of merging onnx-ml and onnx types.
* Fix link to community docs in readme

Addresses #2255

* Update README.md

* Update README.md
* Update managingexperimentalops.md

* Update managingexperimentalops.md

* Rename managingexperimentalops.md to ManagingExperimentalOps.md
* Added negative axes for slice and squeeze opset 11

* added negative axes support for squeeze, unsqueeze, flatten

* added support for negative axes to all the existing ops

* fixed minor if condition missed for axis attr in flatten

* fixed test name for flatten with negative axes

* updated unsqueeze and softmax tests with fix for failures

* fixed typo

* Updating Split op documentations and version

* fixed typo in unsqueeze model

* fixed dim check for unsqueeze

* fixed type cast

* test fix for build failure

* updating onnx model for unsqueeze test

* fixed minor error in type casting
* added test for int64 input to 'where' op

* added onnx model files and docs for test 'where' op with long input

* added missing doc updates
… that do not have matching graph inputs. (#2135)

* Update helper.py

An IR v4 model is not required to have matching graph inputs for all initializers. Update printable_graph to allow for this and output the name, type and shape of initializers with no matching graph input.

* Add test for printable_graph

Add test and tweak messaging

* Fix comment formatting
…lements', 'OneHot' (#2260)

* modified gather docs to support negative indices

* added support for negatice indices to gather_elements and scatter_elements

* fixed documentation formatting as per comments

* Added negatice indices to docs for OneHot op

* GatheND spec for negative indices editted

* fix for comments

* fixed formatting for gather op

* Update onnx/defs/tensor/defs.cc

Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>

* Update docs/Changelog.md

Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>

* added print examples to onehot and gather as per comments

* adding modifies model tests for onehot

* updated doc files

* updating unsqueeze test

* typo fix as per comments
* Fix shapeinference function

* Added shapeinference test for cumsum

* update inference test

* fix test

* minor fix -- shape (1) should be (1,)

* Add whitespace after comma to fix flake warning
* Add a helper function update_inputs_outputs_dims to tools

* fix link to doc

* newline at the end

* add test for tools

* doc props

* nit

* ci tests

* ci tests 2

* accept shapes by dictionary inputs and add more error handling

* Update onnx/tools/update_model_dims.py

nit: rephrasing

Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>

* remove debug line

* fix type annotation

* fix annotation

* fix annotation

* fix annotation

* fix flake8
* sequence related ops

* refine docs

* extend hasInputShape to Sequence

* refining naming and error checking

* refine descriptions
* fix resize shape inference issue in opset10

* include opset10 upsample as well

* nit: const auto*

* rename 'opset7' to 'opset7_to_10'
* Added more test cases for Unsqueeze

* Added a test case for unsqueezing 3 dims

Also renamed the 1 dim test cases slightly.

* Added more test cases for Unsqueeze

* Added a test case for unsqueezing 3 dims

Also renamed the 1 dim test cases slightly.

* Update docs/Operators.md

Feedback from wschin to fix axis bounds.

Co-Authored-By: Wei-Sheng Chin <wschin@outlook.com>

* Re-ran update_doc.sh
* support attribute as empty string

* support attribute as empty string

* code collation
* Add description of default type about y_zero_point

In QuantizeLinear input document.

* Update Changelog.md

* Update Operators.md
* Pad spec update

* More changes

* More changes

* Make pads and value attributes inputs in Pad operator

* More changes

* More changes

* More cahnges

* More changes

* Remove tab

* Fix formatting issues

* More changes

* Pad spec update

* More changes

* More changes

* Prevent unused variables from generating warnings across all platforms.  (#1930)

* Change the return type for the zipmap operator to match the description in the spec.

* Prevent unused variables from generating warnings across all platforms.
This was observed in onnxruntime when __ONNX_NO_DOC_STRINGS was enabled.

* nit change

* Shape Inference Tests for QOps (#1929)

* fix shape inference and add tests for shape inference

* cosmetic fixes

* plus some formatting

* Fix shape inference for matmul (#1941)

* Fix shape inference for matmul when there is no input shape, and provide better coverage for testcases

* add test for qlinearmatmul as weel

* Make pads and value attributes inputs in Pad operator

* More changes

* More changes

* More cahnges

* More changes

* Remove tab

* Fix formatting issues

* More changes

* Fix line ending issue

* Update Operators md file

* Fix typo

* Updating TestCoverage.md file

* Nit fix

* Fix accidental revert

* PR feedback

* More PR feedback changes

* Optimizer passes changes

* Remove unnecessary line in def file

* More formatting changes

* Add 2 files missed previously

* Commit missed out file

* Fix build break

* Update tests

* Initial commit

* Formatting

* Refactor ParseRawData

* More refactroing changes

* Introduce shape inference failure in case of wrong number of pad values

* Resolve comments

* Avoid vector copy

* Fix comment

* More changes

* Update Changelog.md

* Def changes

* More updates

* Formatting

* Check-in tests

* Update docs

* Update Changelog.md

* Docs update

* Update Changelog.md

* Update Changelog.md

* Resolve comments

* Add docs

* Addign docs

* Update Changelog.md

* Build break fix

* Fix build break

* Add optimizer tests for older opset Pad

* Add back older opset Pad shape inference tests

* Fix build break

* Fix build break

* Account for Value to Constant_value change in some comments
* change incorrect use of ValueError to TypeError

* change TypeError

* message
fdwr and others added 27 commits November 24, 2019 08:25
* fix the optimize pass of fuse_consecutive_transposes

* update the bound checker

* make sure the graph and input/output tensors are consistent before and after optimization
* correct typeerror

* value data type correction

* little value
* Edited PythonAPIOverview.md

The example given in the "Creating an ONNX Model Using Helper
Functions" example.

* Edited PythonAPIOverview.md

The example given in the "Creating an ONNX Model Using Helper
Functions" example was not working as expected.

Running the given code would throw a ValidationError() regarding
the node specification (i.e.: "Context: Bad node spec").

This change uses the current node specification, solving the issue.
* add 8 bit support to some reduction ops

* plus updates
* add 8 bit support to maxpool op

* plus review comments
Before defining operator<<(std::ostream&, const Status&).

Co-authored-by: Lu Fang <30275821+houseroad@users.noreply.github.com>
The order of arguments in implementation.cc mismatches with
the header. Since `check_type` is an optional argument, it
should appear after `opset_imports`.

Co-authored-by: bddppq <baidingding7@gmail.com>
…11 (the opset version of the latest stable), but 10 (#2478)

Co-authored-by: Ke Zhang <kezhan@microsoft.com>
Co-authored-by: Ke Zhang <kezhan@microsoft.com>
Draft was shared on Gitter for feedback in December and approved by Steering Committee on 1/9
* Keep symbolic dims in Concat with a single input

When there is only a single input, we need to discard the
symbolic dimension in the specified axis.

* Validate axis of Concat with a single input

Co-authored-by: Ke Zhang <kezhan@microsoft.com>
* Fix shape inference for Split with split attribute

This fixes #1735

* Set rank even when split dimension is unknown

* Let shape inference fail for invalid split

* Fail shape inference for inequal division

* Ignore Python type error in the unittest

* Remove tests for failure scenarios

* Stop using camel case for local variables

Co-authored-by: Ke Zhang <kezhan@microsoft.com>
…nto other markdown rather than versioning.md.
…nto other markdown rather than versioning.md.
@fdwr fdwr closed this Jan 16, 2020
@fdwr fdwr deleted the master branch January 16, 2020 19:07
@fdwr
Copy link
Contributor Author

fdwr commented Jan 16, 2020

Fixed PR here, with correct CLA-associated commits: #2555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants