Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activation of merge queue in onnx/onnx? #4884

Closed
andife opened this issue Feb 10, 2023 · 5 comments
Closed

Activation of merge queue in onnx/onnx? #4884

andife opened this issue Feb 10, 2023 · 5 comments
Labels
CI pipelines Issues related to the CI pipeline

Comments

@andife
Copy link
Member

andife commented Feb 10, 2023

Hi,
maybe we should activate merge queue (https://github.blog/changelog/2023-02-08-pull-request-merge-queue-public-beta/) in this repo here?
@jcwchen
Copy link
Member

jcwchen commented Feb 10, 2023

Thanks @andife. It seems useful. cc @prasanthpul

@justinchuby justinchuby mentioned this issue Feb 13, 2023
Closed
@prasanthpul
Copy link
Member

enabled

@jcwchen
Copy link
Member

jcwchen commented Feb 13, 2023

Currently the merge queue is not working properly. See #4851 (comment). We need to make some changes in our pipeline to accommodate it. Not sure whether DCO can be used in the merge queue though. I am confirming it with the GitHub team. If no, we might need to disable it for now. I will keep you in the loop.

@jcwchen jcwchen added the CI pipelines Issues related to the CI pipeline label Feb 13, 2023
@jcwchen jcwchen mentioned this issue Feb 14, 2023
Merged
@jcwchen
Copy link
Member

jcwchen commented Feb 14, 2023 •
edited
Loading

image

With this PR: #4890, most of our required pipelines are now running, but I still cannot find a way to make DCO run in the merge queue... Here is the related issue: dcoapp/app#199. I also asked here.

Since it is really blocking us merging our PRs, I think for now we should disable it. @prasanthpul could you please disable merge-queue for now? Once the DCO issue has been resolved, we can re-enable it then. Thanks!

@jcwchen jcwchen reopened this Feb 14, 2023
@jcwchen jcwchen mentioned this issue Jul 6, 2023
Merged
jcwchen added a commit that referenced this issue Jul 7, 2023
@jcwchen
Dummy dco workflow to enable merge queue (#5398)
37f4ce6 
### Description
<!-- - Describe your changes. -->
Create a dummy dco workflow to enable merge queue: it won't check
anything, but it should make DCO pass in the merge queue. The PR itself
has already checked DCO and there is no need to check it again in the
merge queue. Ideally with this PR
#4890, we should finally be able to use
merge queue feature in onnx repo. I don't not sure whether it can really
work, but it's worth a shot.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
A workaround to enable merge_queue for DCO workflow:
#4884. Now onnx repo has more PRs to
merge every day and having this merge queue feature can save a lot of
time for merging multiple PRs.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen added a commit that referenced this issue Jul 7, 2023
@jcwchen
Enable merge queue in pipelines: GitHub Action, AzurePipelines (#4890)
dd8fcb0 
### Description
<!-- - Describe your changes. -->
- Add merge_group to required GitHub Action pipeline
- Add `gh-readonly-queue/main/**` in AzurePipelines
### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Enable for the new merge queue feature:
#4884

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Copy link
Member

jcwchen commented Jul 7, 2023

With the workaround: #5398, now merge queue has finally worked in onnx repo! TODO item has been tracked by: #5399. Close this issue as completed.

@jcwchen jcwchen closed this as completed Jul 7, 2023
hamptonm1 pushed a commit to hamptonm1/onnx that referenced this issue Jul 10, 2023
@jcwchen @MegoHam21
Dummy dco workflow to enable merge queue (onnx#5398)
086ad79 
### Description
<!-- - Describe your changes. -->
Create a dummy dco workflow to enable merge queue: it won't check
anything, but it should make DCO pass in the merge queue. The PR itself
has already checked DCO and there is no need to check it again in the
merge queue. Ideally with this PR
onnx#4890, we should finally be able to use
merge queue feature in onnx repo. I don't not sure whether it can really
work, but it's worth a shot.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
A workaround to enable merge_queue for DCO workflow:
onnx#4884. Now onnx repo has more PRs to
merge every day and having this merge queue feature can save a lot of
time for merging multiple PRs.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Megan Hampton <hamptonm@us.ibm.com>
hamptonm1 pushed a commit to hamptonm1/onnx that referenced this issue Jul 10, 2023
@jcwchen @MegoHam21
Enable merge queue in pipelines: GitHub Action, AzurePipelines (onnx#…
b8c7bde 
…4890)

### Description
<!-- - Describe your changes. -->
- Add merge_group to required GitHub Action pipeline
- Add `gh-readonly-queue/main/**` in AzurePipelines
### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Enable for the new merge queue feature:
onnx#4884

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Megan Hampton <hamptonm@us.ibm.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this issue Jul 28, 2023
@jcwchen @adityagoel4512
Dummy dco workflow to enable merge queue (onnx#5398)
30de7ba 
### Description
<!-- - Describe your changes. -->
Create a dummy dco workflow to enable merge queue: it won't check
anything, but it should make DCO pass in the merge queue. The PR itself
has already checked DCO and there is no need to check it again in the
merge queue. Ideally with this PR
onnx#4890, we should finally be able to use
merge queue feature in onnx repo. I don't not sure whether it can really
work, but it's worth a shot.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
A workaround to enable merge_queue for DCO workflow:
onnx#4884. Now onnx repo has more PRs to
merge every day and having this merge queue feature can save a lot of
time for merging multiple PRs.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this issue Jul 28, 2023
@jcwchen @adityagoel4512
Enable merge queue in pipelines: GitHub Action, AzurePipelines (onnx#…
4c2267a 
…4890)

### Description
<!-- - Describe your changes. -->
- Add merge_group to required GitHub Action pipeline
- Add `gh-readonly-queue/main/**` in AzurePipelines
### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Enable for the new merge queue feature:
onnx#4884

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this issue Jul 28, 2023
@jcwchen @adityagoel4512
Dummy dco workflow to enable merge queue (onnx#5398)
b47e821 
### Description
<!-- - Describe your changes. -->
Create a dummy dco workflow to enable merge queue: it won't check
anything, but it should make DCO pass in the merge queue. The PR itself
has already checked DCO and there is no need to check it again in the
merge queue. Ideally with this PR
onnx#4890, we should finally be able to use
merge queue feature in onnx repo. I don't not sure whether it can really
work, but it's worth a shot.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
A workaround to enable merge_queue for DCO workflow:
onnx#4884. Now onnx repo has more PRs to
merge every day and having this merge queue feature can save a lot of
time for merging multiple PRs.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this issue Jul 28, 2023
@jcwchen @adityagoel4512
Enable merge queue in pipelines: GitHub Action, AzurePipelines (onnx#…
e69178a 
…4890)

### Description
<!-- - Describe your changes. -->
- Add merge_group to required GitHub Action pipeline
- Add `gh-readonly-queue/main/**` in AzurePipelines
### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Enable for the new merge queue feature:
onnx#4884

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this issue Jul 28, 2023
@jcwchen @adityagoel4512
Dummy dco workflow to enable merge queue (onnx#5398)
f4cb271 
<!-- - Describe your changes. -->
Create a dummy dco workflow to enable merge queue: it won't check
anything, but it should make DCO pass in the merge queue. The PR itself
has already checked DCO and there is no need to check it again in the
merge queue. Ideally with this PR
onnx#4890, we should finally be able to use
merge queue feature in onnx repo. I don't not sure whether it can really
work, but it's worth a shot.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
A workaround to enable merge_queue for DCO workflow:
onnx#4884. Now onnx repo has more PRs to
merge every day and having this merge queue feature can save a lot of
time for merging multiple PRs.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this issue Jul 28, 2023
@jcwchen @adityagoel4512
Enable merge queue in pipelines: GitHub Action, AzurePipelines (onnx#…
11c6cc8 
…4890)

<!-- - Describe your changes. -->
- Add merge_group to required GitHub Action pipeline
- Add `gh-readonly-queue/main/**` in AzurePipelines
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Enable for the new merge queue feature:
onnx#4884

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI pipelines Issues related to the CI pipeline
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcwchen @andife @prasanthpul