Pull Request Merge Queue Public Beta Feedback #46757
Replies: 256 comments 371 replies
-
One thing I noticed immediately is that when clicking on "Merge when ready", it doesn't allow specifying the commit message/description. This can be alleviated to an extent by changing the default commit message to use the PR title/description, but that's not ideal. |
Beta Was this translation helpful? Give feedback.
-
@willsmythe Great with the queue reaching public beta! I've written some feedback on the Merge Queue a while back, when we tested it in the private beta. Didn't work for us (for the reasons mentioned in my feedback). Awesome if you'd like to take a quick look and respond: (in short, we want the queue to support a semi-linear history, something which e.g. AzureDevOps support, see https://devblogs.microsoft.com/devops/pull-requests-with-rebase/#semi-linear-merge) While I have your attention, I'd also love to hear your thoughts on these two:
(also related to PR workflow) |
Beta Was this translation helpful? Give feedback.
-
I'm trying out this feature in a sample repo, but the |
Beta Was this translation helpful? Give feedback.
-
I'm not quite sure why this is limited to organizations. That seems arbitrary. Individual users could use them. Dependabot notices come in waves for me so tossing them all into a merge queue would be awesome. |
Beta Was this translation helpful? Give feedback.
-
Is there a way to view historical merges in the merge queue? It would be useful to see which PRs were merged as part of the same group, for instance. |
Beta Was this translation helpful? Give feedback.
-
This isn't working for us at all. The checks are staying on pending for every PR even though they completed on them prior to entering the Queue and they are added to our workflow file as:
|
Beta Was this translation helpful? Give feedback.
-
Super excited to see this in public beta! Over on PrairieLearn/PrairieLearn#7131, after adding a PR to the merge queue, removing it, then adding it again, I see a weird commit: If I click on the commit, there's a message that says "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository." I've never seen this before, so I can only assume that this is something to do with merge queues. I'm also facing the same issue others are reporting where the checks never run. |
Beta Was this translation helpful? Give feedback.
-
I'm trying to figure out the behavior w.r.t. to the "Merge method" setting. My goal is to have each PR result in a single revision to the base branch, so I currently have PRs set to squash. The base branch has a protection to enforce linear history. What "Merge method" setting for merge queues will ensure that each PR in the queue still ends up as exactly one revision? I am concerned that e.g. "Squash and merge" here implies squashing all of the PRs in the queue into a single revision. |
Beta Was this translation helpful? Give feedback.
-
I'm using a workflow to validate that every PR title matches conventions (using https://github.com/amannn/action-semantic-pull-request). The status check this action adds is configured as required for the target branch. Having this setup causes the merge queue to stall, because the workflow never runs and the check is never set. That's because the workflow is configured to run only on What is the recommendation for having validation against the PR itself? |
Beta Was this translation helpful? Give feedback.
-
If I try to set the "Status check timeout" to anything more than 127, it returns a 500 error. 7-bit setting? I don't see this limit referenced in the documentation anywhere. |
Beta Was this translation helpful? Give feedback.
-
When a PR is in a merge queue, one of the options in the
I have no idea what it means to "jump the queue". Does it mean it merges immediately? Does it mean it is removed from the queue and goes back to an unmerged state? Something else? I also checked what I thought was the documentation on merge queues and didn't see anything related to that. |
Beta Was this translation helpful? Give feedback.
-
If I click "Merge when ready" on a PR, it goes into a merge queue. But if I have a Dependabot PR and comment If this is expected behavior (like it's waiting until the queue is cleared or something), that is not being communicated. I would hope that either GitHub or Dependabot would explain when it will be added. If it's a bug instead, I hope it will be fixed. |
Beta Was this translation helpful? Give feedback.
-
We want to hear from you on how we can improve pull request merge queue, now in public beta for repos on GitHub Enterprise Cloud and open source organizations! 🎉 See the changelog for more details.
Let us know how we can make the feature work better for you!
👉 Important: configuring your CI
Before enabling merge queue for a branch, make sure your CI is configured to build the temporary branches created by the queue. This is the most common problem we're seeing.
For GitHub Actions, add
merge_group
as a trigger (underon
) to ensure this workflow is run for queue-created branchesFor other CI services, you may need to update your branch filters or triggers to build branches starting with the prefix
gh-readonly-queue/{base_branch}/
See the docs for more details.
🐛 Known issues
Some of the more common or noteworthy issues we are tracking:
Actions workflows not triggering on(fixed)merge_group
@depdendabot merge
command does not working (Dependabot team is evaluating)🚀 Top feature requests
Beta Was this translation helpful? Give feedback.
All reactions