Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Bump Conv to accept bfloat16 #6071

Closed
thiagocrepaldi opened this issue Apr 9, 2024 · 0 comments · Fixed by #6099
Closed

[Feature request] Bump Conv to accept bfloat16 #6071

thiagocrepaldi opened this issue Apr 9, 2024 · 0 comments · Fixed by #6099
Assignees
@thiagocrepaldi
Labels
enhancement Request for new feature or operator operator Issues related to ONNX operators
Milestone
1.17

Comments

@thiagocrepaldi
Copy link

System information

main

What is the problem that this feature solves?

Currently, Conv-11 only accepts input T : tensor(float16), tensor(float), tensor(double)

Alternatives considered

No response

Describe the feature

Just add bfloat16 to the supported dtype list.
Should we extend bfloat16 to all operators that only support float16 currently?

Will this influence the current api (Y/N)?

Y

Feature Area

operators

Are you willing to contribute it (Y/N)

None

Notes

No response
@thiagocrepaldi thiagocrepaldi added the enhancement Request for new feature or operator label Apr 9, 2024
This was referenced Apr 9, 2024
Closed
Closed
@justinchuby justinchuby added the operator Issues related to ONNX operators label Apr 16, 2024
@justinchuby justinchuby added this to the 1.17 milestone Apr 16, 2024
@thiagocrepaldi thiagocrepaldi mentioned this issue Apr 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2024
Add bfloat16 to all relevant ops (#6099)
4e7289d 
Reland #6079

Fixes #3842
Fixes #6071
Fixes #4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
isdanni pushed a commit to isdanni/onnx that referenced this issue May 6, 2024
@isdanni
Add bfloat16 to all relevant ops (onnx#6099)
c7b80ec 
Reland onnx#6079

Fixes onnx#3842
Fixes onnx#6071
Fixes onnx#4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Signed-off-by: isdanni <leedanni@gmail.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this issue Jun 6, 2024
@gramalingam
Add bfloat16 to all relevant ops (onnx#6099)
480d74f 
Reland onnx#6079

Fixes onnx#3842
Fixes onnx#6071
Fixes onnx#4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this issue Jul 20, 2024
@andife
Add bfloat16 to all relevant ops (onnx#6099)
b05d794 
Reland onnx#6079

Fixes onnx#3842
Fixes onnx#6071
Fixes onnx#4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagocrepaldi thiagocrepaldi

Labels
enhancement Request for new feature or operator operator Issues related to ONNX operators
Projects
None yet
Milestone
1.17
2 participants
@thiagocrepaldi @justinchuby