Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bfloat16 to all relevant ops #6099

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

thiagocrepaldi
Copy link

@thiagocrepaldi thiagocrepaldi commented Apr 24, 2024

Reland #6079

Fixes #3842
Fixes #6071
Fixes #4051

@gramalingam @justinchuby FYI

@thiagocrepaldi thiagocrepaldi added auto update doc Generate md/proto files automatically using the CI pipeline and removed auto update doc Generate md/proto files automatically using the CI pipeline labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (83194ed) to head (21c24bc).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6099      +/-   ##
==========================================
+ Coverage   56.95%   57.03%   +0.08%     
==========================================
  Files         506      506              
  Lines       30467    30935     +468     
  Branches     4592     4592              
==========================================
+ Hits        17353    17645     +292     
- Misses      12285    12465     +180     
+ Partials      829      825       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thiagocrepaldi thiagocrepaldi added auto update doc Generate md/proto files automatically using the CI pipeline operator Issues related to ONNX operators run release CIs Use this label to trigger release tests in CI release notes Important changes to call out in release notes labels Apr 24, 2024
#include "onnx/defs/function.h"
#include "onnx/defs/math/utils.h"
#include "onnx/defs/schema.h"
#include "onnx/defs/tensor_proto_util.h"

namespace ONNX_NAMESPACE {

bool BuildContextDependentFunctionBody_opset13(

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 111 lines.
return {"tensor(float16)", "tensor(float)", "tensor(double)"};
}

std::function<void(OpSchema&)> PoolOpSchemaGenerator_opset19(

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 113 lines.

ONNX_OPERATOR_SET_SCHEMA(ConvTranspose, 11, OpSchema().FillUsing(ConvTransposeOpSchemaGenerator_opset11("a filter")));

std::function<void(OpSchema&)> ConvOpSchemaGenerator_opset11(const char* filter_desc) {

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 103 lines.
convPoolShapeInference_opset19(ctx, true, false, 0, 1);
}));

std::function<void(OpSchema&)> ConvTransposeOpSchemaGenerator_opset11(const char* filter_desc) {

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 121 lines.
}
}
}
std::function<void(OpSchema&)> RNNDocGenerator_opset14(const char* /*name*/) {

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 103 lines.
@thiagocrepaldi thiagocrepaldi removed the auto update doc Generate md/proto files automatically using the CI pipeline label Apr 24, 2024
Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
@thiagocrepaldi
Copy link
Author

everything passing, except the mac errors during python setup stage

@thiagocrepaldi thiagocrepaldi self-assigned this Apr 25, 2024
@thiagocrepaldi
Copy link
Author

@gramalingam regarding the comment to refactor the test engine to select ir10 instead of test list, can we make this as a follow up?

this feature is not strictly related to bfloat16 and this pr is already quite big

@gramalingam
Copy link
Contributor

@gramalingam regarding the comment to refactor the test engine to select ir10 instead of test list, can we make this as a follow up?

this feature is not strictly related to bfloat16 and this pr is already quite big

sure, that's fine, thanks!

@gramalingam gramalingam added this pull request to the merge queue Apr 25, 2024
Merged via the queue into onnx:main with commit 4e7289d Apr 25, 2024
99 of 123 checks passed
@justinchuby justinchuby added this to the 1.17 milestone Apr 25, 2024
isdanni pushed a commit to isdanni/onnx that referenced this pull request May 6, 2024
Reland onnx#6079

Fixes onnx#3842
Fixes onnx#6071
Fixes onnx#4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Signed-off-by: isdanni <leedanni@gmail.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Jun 6, 2024
Reland onnx#6079

Fixes onnx#3842
Fixes onnx#6071
Fixes onnx#4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
Reland onnx#6079

Fixes onnx#3842
Fixes onnx#6071
Fixes onnx#4051

@gramalingam @justinchuby FYI

Signed-off-by: Thiago Crepaldi <thiagofc@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator Issues related to ONNX operators release notes Important changes to call out in release notes run release CIs Use this label to trigger release tests in CI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature request] Bump Conv to accept bfloat16 conv bfloat16 Add bfloat16 to all relevant ops
3 participants