-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable onnxifi_test_driver_gtests in CI #1401
Conversation
cmake/unittest.cmake
Outdated
@@ -62,6 +62,10 @@ function(AddTest) | |||
target_link_libraries(${_UT_TARGET} ${PROTOBUF_LIBRARIES}) | |||
endif() | |||
|
|||
if(ONNX_DUMMY_BACKEND) | |||
target_compile_definitions(${_UT_TARGET} PUBLIC "ONNX_DUMMY_BACKEND=true") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need "-DONNX_DUMMY_BACKEND"? (but i'm not 100% certain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually whether -D or not it doesnt works...
9041475
to
bab6e6a
Compare
6dce4e1
to
8cc23af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@rdzhabarov oh I forgot telling you I updated the doc of "resolved" "unsolved" here =) |
Using onnxifi dummy backend.