-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark PROTOBUF_INCLUDE_DIRS as BUILD_INTERFACE #1466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okapies Hi! Thanks for you contribution!
Would you mind sign the CLA first?
I'm sorry for my late response. I signed your CLA. Could you please check it? Thanks. @zrphercule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
It fixes a failure when running
cmake
command if:onnx
project is included in other CMake project as a subdirectory and put its outputs tobuild
directoryand
protobuf
binary is also put in thebuild
directorybecause
PROTOBUF_INCLUDE_DIRS
is not marked asBUILD_INTERFACE
intarget_include_directories
.