Add Scan type/shape inferencing #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper to merge two shapes.
|
With the introduction of control-flow ops, we need to extend the InferenceContext to enable recursive shape-inference for sub-graphs of control-flow ops. @houseroad @bddppq @linkerzhang can you please take a look at the extension to the InferenceContext API in this PR for this purpose? |
gramalingam
reviewed
Oct 12, 2018
gramalingam
reviewed
Oct 14, 2018
- Validate types match the Scan constraints. - Fix a consistency issue in shape_inference.h where a couple of methods were using int instead of size_t.
…tor[] for compatibility with protobuf 2.6.
|
Hi @anderspapitto @linkerzhang : any feedback on the extension to InferenceContext api? |
…for a sub-graph represented by a GraphProto attribute in the current node. Split out from PR 1503 which also adds type/shape inferencing for the sub-graph in the Scan operator.
…apeInferencingForGraphProtoAttributes
… of https://github.com/skottmckay/onnx into EnableRecursiveShapeInferencingForGraphProtoAttributes
…apeInferencingForGraphProtoAttributes
… a separate interface. Update ONNX level implementation to enable graph inferencing for GraphProto attributes in nodes.
…apeInferencingForGraphProtoAttributes
…apeInferencingForGraphProtoAttributes
Merge in some changes to subgraph inferencing structure.
Fix some const-ness issues. Make naming more consistent.
…apeInferencingForGraphProtoAttributes
… of https://github.com/skottmckay/onnx into EnableRecursiveShapeInferencingForGraphProtoAttributes
… into AddScanShapeInferencing
…ay/onnx into AddScanShapeInferencing
|
Updated with changes from PR to separate InferenceContext changes out. #1548 |
…cing, and subgraph inferencing when contained in a Scan node.
linkerzhang
approved these changes
Oct 31, 2018
|
Thank you very much! |
hariharans29
pushed a commit
to hariharans29/onnx
that referenced
this pull request
Aug 15, 2019
* Add Scan type/shape inferencing. Add helper to merge two shapes. * Tweak doco a little. * Add hook to InferenceContext for subgraph inferencing. * Address PR comment * Address PR comments. - Validate types match the Scan constraints. - Fix a consistency issue in shape_inference.h where a couple of methods were using int instead of size_t. * Use RepeatedPtrField::Get instead of operator[] for compatibility with protobuf v2.6 * Update Scan inferencing to use RepeatedPtrField::Get instead of operator[] for compatibility with protobuf 2.6. * Add hook to InferenceContext to allow running type/shape inferencing for a sub-graph represented by a GraphProto attribute in the current node. Split out from PR 1503 which also adds type/shape inferencing for the sub-graph in the Scan operator. * Re-work the setup a little to abstract out the graph inferencing into a separate interface. Update ONNX level implementation to enable graph inferencing for GraphProto attributes in nodes. * Add #include <memory> for linux build * Use stl_backports.h for make_unique * Fix some linux build issues. * Fix linux C++11 build issue. * Update to new subgraph inferencing structure. * Add inputData to inferencing API. Fix some const-ness issues. Make naming more consistent. * Update to pass input data to subgraph inferencing. * Trigger * Trigger build * Trigger * Add unit test for GraphInferencer that checks direct subgraph inferencing, and subgraph inferencing when contained in a Scan node. * Save with debug setup * Add python test for Scan shape inferencing. * Add #type annotation * Fix whitespace in py file.
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Add Scan type/shape inferencing. Add helper to merge two shapes. * Tweak doco a little. * Add hook to InferenceContext for subgraph inferencing. * Address PR comment * Address PR comments. - Validate types match the Scan constraints. - Fix a consistency issue in shape_inference.h where a couple of methods were using int instead of size_t. * Use RepeatedPtrField::Get instead of operator[] for compatibility with protobuf v2.6 * Update Scan inferencing to use RepeatedPtrField::Get instead of operator[] for compatibility with protobuf 2.6. * Add hook to InferenceContext to allow running type/shape inferencing for a sub-graph represented by a GraphProto attribute in the current node. Split out from PR 1503 which also adds type/shape inferencing for the sub-graph in the Scan operator. * Re-work the setup a little to abstract out the graph inferencing into a separate interface. Update ONNX level implementation to enable graph inferencing for GraphProto attributes in nodes. * Add #include <memory> for linux build * Use stl_backports.h for make_unique * Fix some linux build issues. * Fix linux C++11 build issue. * Update to new subgraph inferencing structure. * Add inputData to inferencing API. Fix some const-ness issues. Make naming more consistent. * Update to pass input data to subgraph inferencing. * Trigger * Trigger build * Trigger * Add unit test for GraphInferencer that checks direct subgraph inferencing, and subgraph inferencing when contained in a Scan node. * Save with debug setup * Add python test for Scan shape inferencing. * Add #type annotation * Fix whitespace in py file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TypeAndShapeInferenceFunction for Scan