Update definition of Cast Op to support casting to/from string #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raymondxyang
commented
Dec 20, 2018
raymondxyang
commented
- Update the Cast op to support casting to/from string tensors
- Enable float <-> string test cases
added 9 commits
December 18, 2018 13:57
… pipeline for unicode dtypes in numpy
wschin
reviewed
Jan 3, 2019
linkerzhang
reviewed
Jan 8, 2019
wschin
reviewed
Jan 9, 2019
wschin
reviewed
Jan 9, 2019
wschin
reviewed
Jan 9, 2019
houseroad
reviewed
Jan 9, 2019
There was a problem hiding this comment.
Please only format your changes, otherwise it will be hard for review. Also we need address the precision problem, if the input string is not able to be represented by the target type, what will happen. Also when convert the numeric tensors to string tensors, which representation will be used.
|
@houseroad Reverted the format changes in def.cc |
wschin
reviewed
Jan 10, 2019
wschin
reviewed
Jan 10, 2019
wschin
reviewed
Jan 10, 2019
wschin
reviewed
Jan 10, 2019
wschin
reviewed
Jan 10, 2019
houseroad
reviewed
Jan 14, 2019
added 2 commits
January 16, 2019 13:20
|
Please resolve the conflict. |
hariharans29
pushed a commit
to hariharans29/onnx
that referenced
this pull request
Aug 15, 2019
…1704) * Update definition of Cast Op to support convert to/from tensor(string) * Add test case for casting to/from string; Modify testdata preparation pipeline for unicode dtypes in numpy * Fix cast test case * Fix numpy testcase helper * Fix numpy testcase helper * Lint code * Update test coverage * Update operators.md * Update numpy string releated scripts * Fix flake8 error * Update cast op to support numeric literal values * Fix cast def * Update md files * Update docs for undefined behaviors * Resolve PR comments * Fix syntax errors; Refine operator documentation * Add coverage for Cast testcase * Update operator doc; Change testcase data generating script using existing unicode string handles * Update test data * Update testdata
|
Hi ,a similar problem occured to me . |
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
…1704) * Update definition of Cast Op to support convert to/from tensor(string) * Add test case for casting to/from string; Modify testdata preparation pipeline for unicode dtypes in numpy * Fix cast test case * Fix numpy testcase helper * Fix numpy testcase helper * Lint code * Update test coverage * Update operators.md * Update numpy string releated scripts * Fix flake8 error * Update cast op to support numeric literal values * Fix cast def * Update md files * Update docs for undefined behaviors * Resolve PR comments * Fix syntax errors; Refine operator documentation * Add coverage for Cast testcase * Update operator doc; Change testcase data generating script using existing unicode string handles * Update test data * Update testdata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.