Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shape inference for ConstantOfShape op #1951

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

askhade
Copy link
Contributor

@askhade askhade commented Apr 19, 2019

Bug fix for ConstantOfShape shape inference. mutable_shape for output should be called only when we can do the shape inference.

@askhade askhade requested a review from a team as a code owner April 19, 2019 02:08
Copy link
Contributor

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix.

@askhade askhade changed the title relax shape inference check for concat op Bug fix shape inference for ConstantOfShape op Apr 19, 2019
@askhade askhade changed the title Bug fix shape inference for ConstantOfShape op Fix shape inference for ConstantOfShape op Apr 19, 2019
@askhade askhade closed this Apr 19, 2019
@askhade askhade reopened this Apr 19, 2019
@linkerzhang linkerzhang merged commit 6fb0775 into onnx:master Apr 19, 2019
hariharans29 pushed a commit to hariharans29/onnx that referenced this pull request Aug 15, 2019
* relax shape inferencing check for concat Op

* shape inference fix in constantofshape
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
* relax shape inferencing check for concat Op

* shape inference fix in constantofshape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants