Fix inconsistency in describing graph's initializer. #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is no longer required to be subset of graph's inputs.
|
|
gramalingam
approved these changes
Jun 19, 2019
|
Do I need to do anything to push the change to the master ? |
JamesAllingham
pushed a commit
to JamesAllingham/onnx
that referenced
this pull request
Jul 10, 2019
…nnx#2115) is no longer required to be subset of graph's inputs.
hariharans29
pushed a commit
to hariharans29/onnx
that referenced
this pull request
Aug 15, 2019
…nnx#2115) is no longer required to be subset of graph's inputs.
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
…nnx#2115) is no longer required to be subset of graph's inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to ensure the consistency on relations between graph's input and initializer.
Essentially, a graph's initializer is not required to be subset of the graph's input, and
any initializer not part of graph's input are considered constant definition in the graph.