Remove type info for loop variadic input in Loop op used to compose the Range op #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramalingam
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since "Range" operator is a polymorphic operator in that it supports multiple types, we are unable to bind a specific type to the loop variadic input of the 'Loop' operator used in the composition of the 'Range' operator. Since we didn't have a type bound to it, it was left "undefined" which is not acceptable according to IR. But ONNX model checker accepts missing type altogether for subgraph inputs indicating that ONNX accepts this. Hence, we remove the type altogether for the loop variadic input while preserving type information for the other 2 inputs (iteration count and boolean condition) since we know the element types for these. The makes the resultant "test models" for the 'Range' op valid as per spec (as opposed to now - wherein they are invalid).