Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows py3.5 CI #2529

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix Windows py3.5 CI #2529

merged 1 commit into from
Jan 3, 2020

Conversation

bddppq
Copy link
Member

@bddppq bddppq commented Jan 2, 2020

https://ci.appveyor.com/project/onnx/onnx/builds/29586926/job/0cx9q6ffptkye0cm

ImportError:
IPython 7.10+ supports Python 3.6 and above.
When using Python 2.7, please install IPython 5.x LTS Long Term Support version.
Python 3.3 and 3.4 were supported up to IPython 6.x.
Python 3.5 was supported with IPython 7.0 to 7.9.
See IPython README.rst file for more information:

@bddppq bddppq requested a review from a team as a code owner January 2, 2020 23:19
houseroad
houseroad approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bddppq bddppq force-pushed the fix-win-py3.5-CI branch 4 times, most recently from 7525b16 to 8e12fc0 Compare January 3, 2020 00:51
@bddppq bddppq merged commit 7cebaed into onnx:master Jan 3, 2020
@bddppq bddppq deleted the fix-win-py3.5-CI branch January 3, 2020 01:17
@winnietsang winnietsang added this to the 1.7 milestone Feb 12, 2020
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
@bddppq
Fix Windows py3.5 CI (onnx#2529)
71895bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bddppq @houseroad @winnietsang