Reduce binary size for Linux and Mac package #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
commented
Mar 18, 2021
.github/workflows/release_mac.yml
Outdated
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: [master, rel-*] | |||
| pull_request: | |||
| branches: [rel-*] | |||
| branches: [rel-*, master] # TODO: remove it before merge | |||
|
|
|||
There was a problem hiding this comment.
Mac CI fails because of this pypa/setuptools-scm#542. Will try to reduce binary size as well.
There was a problem hiding this comment.
ONNX decided to deprecate python 3.5 in the following 1.9. Will remove it in this PR to prevent failure caused by Python 3.5 incompatibility
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
etusien
reviewed
Mar 22, 2021
.github/workflows/release_mac.yml
Outdated
| @@ -39,6 +39,8 @@ jobs: | |||
| - name: Install Python dependencies | |||
| run: | | |||
| python -m pip install -q --upgrade pip | |||
| # Latest setuptools-scm-6.0.1 (dependency of setuptools) does not support Python 3.5 anymore | |||
There was a problem hiding this comment.
Is this still relevant if we want to remove support for Python 3.5?
There was a problem hiding this comment.
Good catch. Removed. Thanks
|
can we separate this in 2 PRs... to keep things clean.... Create a new 1 for python deprecation and keep this for binary size reduction. Thanks! |
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sure thing. A new PR (#3353) decouple from this PR |
askhade
approved these changes
Mar 25, 2021
etusien
approved these changes
Mar 25, 2021
postrational
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linux package -- 18.9MB ->11.5MB
Mac package -- 12MB -> 11.3MB
Meanwhile; the total running time will be much faster as well: (Linux 59mins -> 8 mins; Mac 26mins -> 9mins)
Motivation
ONNX 1.8.1 PyPI package becomes much larger than 1.8.0, especially Linux package. The main reason is ONNX upgraded its protobuf-compiler version from 2.6 to 3.11. We need to figure out a reasonable way to shrink protobuf dependency even though it needs to be upgraded.