Add test case container type #3681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
InOutContainerPrototo store test case in/out data so that we don't need to look inside model's input/output type.Motivation and Context
When optional type was added in #3567 , loading test case data got more difficult because the structure of SequenceProto and OptionalProto are very similar and undeterminable when we read the message.
I would like to add
InOutContainerProtomessage type to store in/out data of onnx test cases to make loading of it easier.In addition I've add
reserved_for_containerto check difference with current in/out message type.I haven't run
python onnx/backend/test/cmd_tools.py generate-datasince there could be more improvements to names