Install specified mypy version first in Python Lint CI to make mypy version consistent #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
commented
Sep 8, 2022
| @@ -67,6 +67,9 @@ jobs: | |||
| level: warning | |||
| filter_mode: diff_context | |||
| glob_pattern: "**/*.py" | |||
| - name: Install specified mypy version | |||
| run: | | |||
| python -m pip install -q -r requirements-dev.txt | |||
There was a problem hiding this comment.
I chose requirements-dev.txt instead of pip install mypy==0.782 so we don't have to update a lot of hardcoded versions when upgrading in the future.
liqunfu
approved these changes
Sep 30, 2022
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Install specified mypy version first in Python Lint CI to make mypy version consistent
Motivation and Context
Currently action-mypy is complaining many mypy errors with newer mypy version 0.971. See related discussion: #4495 (comment).
cc @justinchuby Thanks for the solution!