Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install specified mypy version first in Python Lint CI to make mypy version consistent #4498

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Install specified mypy version first in Python Lint CI to make mypy version consistent #4498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9611c5
try to install specified mypy version first
jcwchen Sep 8, 2022
083600f
Merge branch 'main' into jcw/fix-mypy
jcwchen Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ jobs:
level: warning
filter_mode: diff_context
glob_pattern: "**/*.py"
- name: Install specified mypy version
run: |
python -m pip install -q -r requirements-dev.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose requirements-dev.txt instead of pip install mypy==0.782 so we don't have to update a lot of hardcoded versions when upgrading in the future.

- name: mypy
uses: tsuyoshicho/action-mypy@v3
with:
Expand Down