Test case to ensure inference error when element types mismatch #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinchuby Any thoughts? |
|
Thanks for the investigation! In that case maybe we just need to use the latest onnx in ONNX Runtime (I believe that's where I found it) |
ClifHouck
force-pushed
the
clif/dtype_name_in_shape_inference_mismatch/5178
branch
from
7dacc56
to
6390bc8
Compare
ClifHouck
force-pushed
the
clif/dtype_name_in_shape_inference_mismatch/5178
branch
from
25f80d7
to
e8b06a8
Compare
xadupre
approved these changes
Aug 28, 2023
Signed-off-by: Clif Houck <me@clifhouck.com>
Signed-off-by: Clif Houck <me@clifhouck.com>
Signed-off-by: Clif Houck <me@clifhouck.com>
ClifHouck
force-pushed
the
clif/dtype_name_in_shape_inference_mismatch/5178
branch
from
e8b06a8
to
5ecc080
Compare
justinchuby
changed the title
justinchuby
changed the title
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
…#5525) ### Description <!-- - Describe your changes. --> Created a short proof of concept test case to see what happens when element types mismatch. Output from the test: `C++ exception with description "[TypeInferenceError] Inferred elem type differs from existing elem type: (FLOAT) vs (UINT8)" thrown in the test body.` Seems to indicate that `GetElemTypeString` already works as expected. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Investigating onnx#5178, but it seems like it may not actually be a problem? --------- Signed-off-by: Clif Houck <me@clifhouck.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
…#5525) ### Description <!-- - Describe your changes. --> Created a short proof of concept test case to see what happens when element types mismatch. Output from the test: `C++ exception with description "[TypeInferenceError] Inferred elem type differs from existing elem type: (FLOAT) vs (UINT8)" thrown in the test body.` Seems to indicate that `GetElemTypeString` already works as expected. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Investigating onnx#5178, but it seems like it may not actually be a problem? --------- Signed-off-by: Clif Houck <me@clifhouck.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
…#5525) ### Description <!-- - Describe your changes. --> Created a short proof of concept test case to see what happens when element types mismatch. Output from the test: `C++ exception with description "[TypeInferenceError] Inferred elem type differs from existing elem type: (FLOAT) vs (UINT8)" thrown in the test body.` Seems to indicate that `GetElemTypeString` already works as expected. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Investigating onnx#5178, but it seems like it may not actually be a problem? --------- Signed-off-by: Clif Houck <me@clifhouck.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a short proof of concept test case to see what happens when element types mismatch.
Output from the test:
C++ exception with description "[TypeInferenceError] Inferred elem type differs from existing elem type: (FLOAT) vs (UINT8)" thrown in the test body.Seems to indicate that
GetElemTypeStringalready works as expected.Motivation and Context
Investigating #5178, but it seems like it may not actually be a problem?