Add backward conversions from 18->17 for reduce ops #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
|
Should we add a unit test? |
gramalingam
reviewed
Sep 20, 2023
Good point! there is an onnx\test\automatic_upgrade_test.py. we shall add a automatic_downgrade_test to catch such mistakes. #5607 |
justinchuby
previously approved these changes
Sep 20, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
reviewed
Sep 20, 2023
justinchuby
reviewed
Sep 20, 2023
justinchuby
reviewed
Sep 20, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
There was a problem hiding this comment.
lintrunner found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
justinchuby
reviewed
Sep 21, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
added downgrade test |
justinchuby
changed the title
justinchuby
reviewed
Sep 21, 2023
justinchuby
reviewed
Sep 21, 2023
justinchuby
reviewed
Sep 21, 2023
justinchuby
reviewed
Sep 21, 2023
justinchuby
reviewed
Sep 21, 2023
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com>
justinchuby
approved these changes
Sep 22, 2023
justinchuby
reviewed
Sep 22, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
xadupre
reviewed
Sep 22, 2023
|
I was going to merge now to unblock #5613 . Looks like we still need @onnx/sig-operators-approvers |
xadupre
approved these changes
Sep 25, 2023
gramalingam
reviewed
Sep 25, 2023
gramalingam
reviewed
Sep 25, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
reviewed
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backward conversion is needed for reduce ops that have axes attribute changed to input
Motivation and Context
version converter