Fix SegFault bug in shape inference #5990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: opluss <opluss@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5990 +/- ##
==========================================
+ Coverage 56.81% 56.82% +0.01%
==========================================
Files 506 506
Lines 30357 30365 +8
Branches 4589 4590 +1
==========================================
+ Hits 17246 17254 +8
Misses 12283 12283
Partials 828 828 ☔ View full report in Codecov by Sentry. |
Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
|
@cjvolzka @gramalingam may be worthy to be included in 1.16 since this is fixing a memory error. |
gramalingam
reviewed
Mar 4, 2024
gramalingam
approved these changes
Mar 4, 2024
|
@justinchuby I can wait to cut rc2 until this has been cherry-picked into the |
justinchuby
approved these changes
Mar 4, 2024
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
|
I am going to merge as is for us to fix the bug, and then allow the author to create a follow-up. |
cjvolzka
pushed a commit
that referenced
this pull request
Mar 4, 2024
### Description Cherry-pick #5990 into `rel-1.16.0` branch The bug is SegFault during shape inference if the schema not be set inference function. The schema has `CheckInputOutputType` for shape inference and `Verify` for raw node proto. And the behavior is not fully aligned. ### Motivation and Context fixes #5989 --------- Signed-off-by: opluss <opluss@qq.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
cjvolzka
added a commit
that referenced
this pull request
Mar 5, 2024
### Description Cherry-Pick #5990 into `rel-1.16.0` branch The bug is SegFault during shape inference if the schema not be set inference function. The schema has `CheckInputOutputType` for shape inference and `Verify` for raw node proto. And the behavior is not fully aligned. ### Motivation and Context fixes #5989 Signed-off-by: opluss <opluss@qq.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: oPluss <opluss@qq.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
Mar 18, 2024
### Description The bug is SegFault during shape inference if the schema not be set inference function. The schema has `CheckInputOutputType` for shape inference and `Verify` for raw node proto. And the behavior is not fully aligned. ### Motivation and Context fixes onnx#5989 --------- Signed-off-by: opluss <opluss@qq.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: isdanni <leedanni@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
### Description - Add `OpSchema::VerifyInputNum` and `OpSchema::VerifyOutputNum` methods. The logic has been moved from `OpSchema::Verify`. - Replaced the input/output number check logic in `OpSchema::CheckInputOutputType` with calls to the new interfaces. - Without using the `Node(domain::op_type::version)` string pattern in `OpSchema::CheckInputOutputType` when calling `fail_check`, as the `op_type` will be displayed by the shape inference common exception. Otherwise, it would appear redundant. ### Motivation and Context follow-up #5990 resolve #5993 --------- Signed-off-by: opluss <opluss@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug is SegFault during shape inference if the schema not be set inference function.
The schema has
CheckInputOutputTypefor shape inference andVerifyfor raw node proto. And the behavior is not fully aligned.Motivation and Context
fixes #5989