Generalize input/output number check in shape inference #6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: opluss <opluss@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6005 +/- ##
=======================================
Coverage 56.81% 56.81%
=======================================
Files 506 506
Lines 30370 30370
Branches 4592 4592
=======================================
Hits 17256 17256
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Mar 11, 2024
justinchuby
approved these changes
Mar 14, 2024
justinchuby
added
the
review needed: operators approvers
Signed-off-by: opluss <opluss@qq.com>
gramalingam
reviewed
Mar 14, 2024
Signed-off-by: opluss <opluss@qq.com>
justinchuby
reviewed
Mar 15, 2024
gramalingam
approved these changes
Mar 19, 2024
justinchuby
removed
the
review needed: operators approvers
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpSchema::VerifyInputNumandOpSchema::VerifyOutputNummethods. The logic has been moved fromOpSchema::Verify.OpSchema::CheckInputOutputTypewith calls to the new interfaces.Node(domain::op_type::version)string pattern inOpSchema::CheckInputOutputTypewhen callingfail_check, as theop_typewill be displayed by the shape inference common exception. Otherwise, it would appear redundant.Motivation and Context
follow-up #5990
resolve #5993