-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove benchmarking code #6076
Merged
Merged
Remove benchmarking code #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies. Signed-off-by: Justin Chu <justinchu@microsoft.com>
1dc1553
to
989b112
Compare
jcwchen
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clean-up. I also think this is not used by anyone for a while. Please remember to announce it in the next release note.
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies. Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies. Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Jun 6, 2024
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies. Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies. Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
better engineering
Improve engineering quality of the project
dependencies
Pull requests that update a dependency file
release notes
Important changes to call out in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies.