Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarking code #6076

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

justinchuby
Copy link
Contributor

We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies.

@justinchuby justinchuby requested a review from a team as a code owner April 11, 2024 03:08
We the benchmarks are not testing much and thus are not very useful. Removing them to keep code lean and reduce dependencies.

Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby added the better engineering Improve engineering quality of the project label Apr 11, 2024
@jcwchen jcwchen added the dependencies Pull requests that update a dependency file label Apr 11, 2024
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean-up. I also think this is not used by anyone for a while. Please remember to announce it in the next release note.

@justinchuby justinchuby added this to the 1.17 milestone Apr 11, 2024
@justinchuby justinchuby added the release notes Important changes to call out in release notes label Apr 11, 2024
@justinchuby justinchuby added this pull request to the merge queue Apr 12, 2024
Merged via the queue into onnx:main with commit 959744d Apr 12, 2024
20 checks passed
@justinchuby justinchuby deleted the justinchu/remove-bench branch April 12, 2024 16:14
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Apr 12, 2024
We the benchmarks are not testing much and thus are not very useful.
Removing them to keep code lean and reduce dependencies.

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Apr 12, 2024
We the benchmarks are not testing much and thus are not very useful.
Removing them to keep code lean and reduce dependencies.

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Jun 6, 2024
We the benchmarks are not testing much and thus are not very useful.
Removing them to keep code lean and reduce dependencies.

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
We the benchmarks are not testing much and thus are not very useful.
Removing them to keep code lean and reduce dependencies.

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better engineering Improve engineering quality of the project dependencies Pull requests that update a dependency file release notes Important changes to call out in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants