Prroy/fix nb bugs #162
Merged
Prroy/fix nb bugs #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
August 28, 2018 10:05
|
I suggested a fix in #161, I think yours is better. |
xadupre
approved these changes
Nov 1, 2018
wenbingl
approved these changes
Nov 1, 2018
wenbingl
pushed a commit
to wenbingl/onnxmltools
that referenced
this pull request
Nov 14, 2018
* Initial changes * Merged PCA with SVD and added KNN shape calculators in Linear * Merged KNN classifier and regressor files * Added Naive Bayes converters * Addressed PR comments about name changes, reverting to previous names * Removing extra import from init * Added LassoLars and Ridge converters * Fixed issues with running test on NB models * Added comments * Merged LeastSquares with LinearRegressor, added computational graph to NB, etc. * Fixed bug in KNN Classifier * Added calculation of probability to NB converter * Added unit tests * Addressed review comments * Removed duplicate function * Added comment to clarify two output paths * Removed non-ascii character * Fixed topk calculation error in KNNR * Fixed additional cases in PCA * Fixed cntk and scikit versions * Fixed Bernoulli NB bug * Undoing this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Bernoulli NB bug