Fixes #399, casts type column if needed when using operator concat #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadupre
changed the title
|
This pull request introduces 1 alert when merging c3b5eef into 327d538 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 71aa625 into e076e97 - view on LGTM.com new alerts:
|
prabhat00155
reviewed
May 5, 2020
tests/small_titanic.csv
Outdated
| @@ -0,0 +1,39 @@ | |||
| pclass,survived,name,sex,age,sibsp,parch,ticket,fare,cabin,embarked,boat,body,home.dest | |||
There was a problem hiding this comment.
Why are we checking-in this dataset?
There was a problem hiding this comment.
It is not the really dataset, it helps getting data with many types. I can't download the url, it usually makes the unit test fails.
There was a problem hiding this comment.
In that case, do you think it would be better to move this to tests/datasets directory. This directory could be used in future for similar cases.
prabhat00155
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.