Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an end2end example with tf.keras #1103

Merged
merged 9 commits into from Sep 18, 2020
Merged

Add an end2end example with tf.keras #1103

merged 9 commits into from Sep 18, 2020

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Sep 15, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2020

This pull request introduces 3 alerts when merging 8050277 into 353e46f - view on LGTM.com

new alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2020

This pull request introduces 3 alerts when merging 2d97157 into 353e46f - view on LGTM.com

new alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2020

This pull request introduces 4 alerts when merging 3714e1d into 353e46f - view on LGTM.com

new alerts:

  • 4 for Unused import

print('ort:', timeit.timeit("session.run(None, {'input_1:0': input})",
number=100, globals=globals()))

########################################
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tflite does not contribute much to a example how to convert tf->onnx.
We should remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

index = input_details[0]['index']


def tflite_predict(input, interpreter=interpreter, index=index):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tflite does not contribute much to a example how to convert tf->onnx.
We should remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll remove it from the example. Do I keep an example about tflite?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would confuse users if we have tflite in examples since we don't support it.
Best to remove it completely.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@xadupre xadupre merged commit b1eccce into onnx:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants