Add support for operators RFFT, ComplexAbs #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging db08e76 into b4ac342 - view on LGTM.com new alerts:
|
TomWildenhain-Microsoft
suggested changes
Sep 25, 2020
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
TomWildenhain-Microsoft
suggested changes
Sep 28, 2020
tests/test_backend.py
Outdated
| @@ -3624,6 +3629,27 @@ def test_conv2d_1_kernel_as_input(self): | |||
| [1., 1., 4.]], dtype=np.float32).reshape(_KERNEL3x3) | |||
| self._conv_kernel_as_input_test(x_val, w_val) | |||
|
|
|||
| @unittest.skipIf(tf_signal is None, reason="TF does not have submodule signal.") | |||
There was a problem hiding this comment.
Can you make this check depend on the TF version instead of doing the whole try/catch import thing?
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
guschmue
approved these changes
Sep 28, 2020
TomWildenhain-Microsoft
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes also validated with model https://tfhub.dev/google/nonsemantic-speech-benchmark/trill-distilled/3.