fix shape inference for onnx-1.8 #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guenther Schmuelling <guschmue@microsoft.com>
|
This pull request introduces 2 alerts when merging 0b293b5 into 1bc3079 - view on LGTM.com new alerts:
|
tf2onnx/schemas.py
Outdated
| @@ -156,7 +156,7 @@ def build_onnx_op(node): | |||
| try: | |||
| inferred_model = shape_inference.infer_shapes(model_proto) | |||
| except Exception: # pylint: disable=broad-except | |||
| logger.warning( | |||
| logger.info( | |||
There was a problem hiding this comment.
I have liked that this is a warning since it often indicates a problem with freezing.
TomWildenhain-Microsoft
suggested changes
Nov 5, 2020
| @@ -16,7 +16,7 @@ stages: | |||
| - template: 'templates/job_generator.yml' | |||
| parameters: | |||
| python_versions: ['3.7'] | |||
| tf_versions: ['1.14.0','1.15.2','2.1.0','2.2.0'] | |||
| tf_versions: ['1.14.0','1.15.2','2.3.0'] | |||
There was a problem hiding this comment.
Add 2.2.0
Suggested change
| tf_versions: ['1.14.0','1.15.2','2.3.0'] | |
| tf_versions: ['1.14.0','1.15.2','2.2.0','2.3.0'] |
Signed-off-by: Guenther Schmuelling <guschmue@microsoft.com>
TomWildenhain-Microsoft
approved these changes
Nov 5, 2020
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This pull request introduces 2 alerts when merging 6b11bbc into 373908e - view on LGTM.com new alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
ci pipeline completed but notify to github seems missing ... forced the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guenther Schmuelling guschmue@microsoft.com
we used to set subgraphs as attributes after calling make_node() but called shape inference in make_node() which makes it hard for shape inference to do something useful. Pass the subgraphs to make_node() so they are set before calling shape inference.