Added rewriter for specific pattern in a 1P model #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 63b6ade into 1cb41b4 - view on LGTM.com new alerts:
|
TomWildenhain-Microsoft
force-pushed
the
tom/layer_norm
branch
from
63b6ade
to
c9cf819
Compare
Signed-off-by: Tom Wildenhain <tomwi@microsoft.com>
TomWildenhain-Microsoft
force-pushed
the
tom/layer_norm
branch
from
c9cf819
to
fcaf4e6
Compare
guschmue
approved these changes
Mar 8, 2021
xadupre
reviewed
Mar 9, 2021
|
|
||
|
|
||
| """ | ||
| tf2onnx.rewrite - Rewrites a specific pattern that appears in some models from the tf layer_norm contrib op |
There was a problem hiding this comment.
We should have a more specific comment. This one does not say which optimization is done here.
There was a problem hiding this comment.
Fair point.
Signed-off-by: Tom Wildenhain <tomwi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wildenhain tomwi@microsoft.com