Merge add86f8 into d564019

Makefile

@@ -18,7 +18,7 @@ test: build deps linters license_check
 	CGO_ENABLED=1 go test -race github.com/onosproject/onos-config/api/...
 
 coverage: # @HELP generate unit test coverage data
-coverage: build deps
+coverage: build deps linters license_check
 	./build/bin/coveralls-coverage
 
 deps: # @HELP ensure that the required dependencies are in place

go.mod

@@ -3,15 +3,18 @@ module github.com/onosproject/onos-config
 go 1.14
 
 require (
+	cloud.google.com/go v0.43.0 // indirect
 	github.com/atomix/go-client v0.2.1
 	github.com/cenkalti/backoff v2.2.1+incompatible
 	github.com/docker/docker v1.13.1
 	github.com/gogo/protobuf v1.3.1
 	github.com/golang/mock v1.3.1
 	github.com/golang/protobuf v1.3.3
+	github.com/google/pprof v0.0.0-20190723021845-34ac40c74b70 // indirect
 	github.com/google/uuid v1.1.1
 	github.com/googleapis/gnostic v0.3.0 // indirect
 	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect
+	github.com/kr/pty v1.1.8 // indirect
 	github.com/mattn/go-colorable v0.1.4 // indirect
 	github.com/mattn/go-isatty v0.0.12 // indirect
 	github.com/onosproject/config-models/modelplugin/devicesim-1.0.0 v0.0.0-20200303111912-723f2289d4c2
@@ -30,6 +33,7 @@ require (
 	github.com/spf13/viper v1.6.2
 	github.com/stretchr/testify v1.5.1
 	go.uber.org/multierr v1.4.0 // indirect
+	golang.org/x/mobile v0.0.0-20190806162312-597adff16ade // indirect
 	golang.org/x/sys v0.0.0-20200212091648-12a6c2dcc1e4 // indirect
 	google.golang.org/genproto v0.0.0-20200212174721-66ed5ce911ce // indirect
 	google.golang.org/grpc v1.27.1

test/utils/gnmi/utils.go

@@ -424,7 +424,6 @@ func CheckDeviceValue(t *testing.T, deviceGnmiClient client.Impl, devicePaths []
 		assert.NoError(t, deviceValuesError, "GNMI get operation to device returned an error")
 		assert.Equal(t, expectedValue, deviceValues[0].PathDataValue, "Query after set returned the wrong value: %s\n", expectedValue)
 		assert.Equal(t, 0, len(extensions))
-		return
 	} else {
 		assert.Fail(t, "Failed to query device: %v", deviceValuesError)
 	}